Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚩 (llm) reborn feature flag #8398

Merged
merged 1 commit into from
Nov 20, 2024
Merged

🚩 (llm) reborn feature flag #8398

merged 1 commit into from
Nov 20, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Nov 19, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • FF & analytics

📝 Description

Add FF and analytics for Reborn II.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Nov 19, 2024 4:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 4:58pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Nov 19, 2024
@LucasWerey LucasWerey marked this pull request as ready for review November 19, 2024 16:08
@LucasWerey LucasWerey requested a review from a team as a code owner November 19, 2024 16:08
@LucasWerey LucasWerey force-pushed the LIVE-14636 branch 2 times, most recently from 8fa5495 to 3e672c6 Compare November 19, 2024 16:12
themooneer
themooneer approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LucasWerey LucasWerey merged commit 724fa8b into develop Nov 20, 2024
54 of 56 checks passed
@LucasWerey LucasWerey deleted the LIVE-14636 branch November 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@LucasWerey LucasWerey

Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasWerey @themooneer