bugfix: 🐛 Spam filtering errors unhandled #8404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mcayuelas-ledger
force-pushed
the
bugfix/spam-filtering
branch
from
a5c3a1b to
800946d
Compare
KVNLS
requested changes
Nov 20, 2024
| const collection = `${accountId}|${contract}`; | ||
| action(collection); | ||
| }); | ||
| if (spams.length > 0) { |
There was a problem hiding this comment.
Can we add a unit test to cover this new use case, please?
mcayuelas-ledger
force-pushed
the
bugfix/spam-filtering
branch
from
800946d to
a03a4cb
Compare
|
Rebasing on latest develop should fix the changesets issue. I was able to get a pass on a copy of this branch here |
mcayuelas-ledger
force-pushed
the
bugfix/spam-filtering
branch
from
a03a4cb to
3375ca6
Compare
themooneer
reviewed
Nov 22, 2024
themooneer
reviewed
Nov 22, 2024
|
|
||
| export const generateNft = (contract: string, tokenId: string) => ({ | ||
| id: encodeNftId("foo", contract, tokenId, "ethereum"), | ||
| tokenId: tokenId, |
There was a problem hiding this comment.
just tokenId is sufficient object-shorthand
themooneer
reviewed
Nov 22, 2024
themooneer
reviewed
Nov 22, 2024
mcayuelas-ledger
force-pushed
the
bugfix/spam-filtering
branch
2 times, most recently
from
cb3ef18 to
3872da7
Compare
mcayuelas-ledger
force-pushed
the
bugfix/spam-filtering
branch
from
3872da7 to
f3e481e
Compare
themooneer
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Fix Sentry errors:
❓ Context
🧐 Checklist for the PR Reviewers