Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebPlatformPlayer): Fixing account names in account selection in … #8445

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

ComradeAERGO
Copy link
Contributor

@ComradeAERGO ComradeAERGO commented Nov 22, 2024

…Webviews

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Dapp Browser Webview

📝 Description

The webview running the dapp-browser enables the selection of accounts.

The names of the accounts were previously gatheres using the getDefaultAccountName function that builds the account name by concatenating the currency of the account with an index.

This was confusing to users as the name built this way did not match the user-given names to the account.

The current fix enable users to display the selected accounts with their user-given names.

BEFORE
https://github.com/user-attachments/assets/73eec2b9-dcc2-42e3-8e53-c0e304da4bf9

AFTER
https://github.com/user-attachments/assets/6561b8ee-a288-4b9c-8947-28d872ef2950

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-14998


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:11pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:11pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:11pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:11pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 22, 2024
CremaFR
CremaFR previously approved these changes Nov 22, 2024
@ComradeAERGO ComradeAERGO marked this pull request as ready for review November 22, 2024 13:43
@ComradeAERGO ComradeAERGO requested a review from a team as a code owner November 22, 2024 13:43
Justkant
Justkant previously approved these changes Nov 22, 2024
@ComradeAERGO ComradeAERGO dismissed stale reviews from Justkant and CremaFR via dd932cd November 22, 2024 13:52
@ComradeAERGO ComradeAERGO force-pushed the fix/account-names-in-webview branch from 4bd2b47 to dd932cd Compare November 22, 2024 13:52
@ComradeAERGO ComradeAERGO merged commit 9b5b5c7 into develop Nov 26, 2024
40 of 43 checks passed
@ComradeAERGO ComradeAERGO deleted the fix/account-names-in-webview branch November 26, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants