Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA] Adding E2E test for Ledger Sync #8448

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Nov 22, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • E2E test (LEDGER SYNC)

πŸ“ Description

Adding e2e test for Ledger Sync:

  • Creation of the trustchain + push of 2 accounts to the cloud with the CLI
  • Connection to the trustchain and checking that the accounts are visible on LLD
  • Trustchain destruction on LLD

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Nov 25, 2024 5:02pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 5:02pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 5:02pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 5:02pm

@VicAlbr VicAlbr marked this pull request as ready for review November 22, 2024 13:40
@VicAlbr VicAlbr requested review from a team as code owners November 22, 2024 13:40
@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Nov 22, 2024
@VicAlbr VicAlbr force-pushed the support/ledger-sync-e2e branch 2 times, most recently from c0fd474 to ac1f499 Compare November 25, 2024 16:01
@VicAlbr VicAlbr merged commit 42df614 into develop Nov 26, 2024
54 of 55 checks passed
@VicAlbr VicAlbr deleted the support/ledger-sync-e2e branch November 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants