fix: NoSuchAppProvider exception learn more link management #8465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
themooneer
force-pushed
the
fix/NSAPLearnMoreManagement
branch
from
9417a0c to
d389153
Compare
| > | ||
| <Trans i18nKey="errors.NoSuchAppOnProvider.learnMoreCTA" /> | ||
| </StyledLinkLearnMoreButton> | ||
| {learnMoreLink && ( |
There was a problem hiding this comment.
as learnMoreTextKey is optional, needs to be checked no?
There was a problem hiding this comment.
@mcayuelas-ledger can you take a look please ?
themooneer
force-pushed
the
fix/NSAPLearnMoreManagement
branch
from
d389153 to
d69961c
Compare
ofreyssinet-ledger
approved these changes
Nov 25, 2024
| learnMoreTextKey: "errors.NoSuchAppOnProvider.learnMoreCTA", | ||
| }; | ||
| default: | ||
| return {}; |
There was a problem hiding this comment.
we don't provide anything for default?
There was a problem hiding this comment.
@mcayuelas-ledger we don't as learnMoreLink depends on apps context
There was a problem hiding this comment.
for example ACRE there is no learnMoreLink, if they want to add it, they should implement it here.
mcayuelas-ledger
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Make the learn more link rendering on NoSuchAppProvider related UI dynamic per appName.
syncOK.mov
❓ Context
🧐 Checklist for the PR Reviewers