Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA] Adding speculos e2e test - User can Select a countervalue #8497

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Nov 27, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Adding E2E test : User can Select a countervalue to display amount in Ledger Live
checks:

  • Counter value is correct on total balance
  • Counter value is correct on balance diff
  • Counter value is correct on Asset row
  • Counter value is correct on Operation row

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 1:54pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 1:54pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 1:54pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 1:54pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 27, 2024
@VicAlbr VicAlbr force-pushed the support/QAA-330 branch 2 times, most recently from c2f99a2 to 677596b Compare November 27, 2024 10:46
@VicAlbr VicAlbr marked this pull request as ready for review November 27, 2024 10:46
@VicAlbr VicAlbr requested review from a team as code owners November 27, 2024 10:46
LucasWerey
LucasWerey previously approved these changes Nov 27, 2024
@VicAlbr VicAlbr requested a review from LucasWerey November 27, 2024 15:37
@VicAlbr VicAlbr merged commit c846a47 into develop Nov 27, 2024
53 checks passed
@VicAlbr VicAlbr deleted the support/QAA-330 branch November 27, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants