Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROTECT-3455] Remove feature_recover_upsell_redirection feature flag from codebase #8503

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

jiyuzhuang
Copy link
Contributor

@jiyuzhuang jiyuzhuang commented Nov 27, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • The feature_recover_upsell_redirection feature flag has been removed, now the new onboarding flow and redirections after onboarding will always take place.

📝 Description

  • The feature_recover_upsell_redirection feature flag has been removed, now the new onboarding flow and redirections after onboarding will always take place.
    `
  • The BackupStep components for both LLD and LLM are not used in any other place, so they have been removed.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jiyuzhuang jiyuzhuang self-assigned this Nov 27, 2024
@jiyuzhuang jiyuzhuang requested review from a team as code owners November 27, 2024 14:02
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 3:19pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 3:19pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 3:19pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 3:19pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Nov 27, 2024
@jiyuzhuang jiyuzhuang force-pushed the feat/protect-3455-remove-ff branch 2 times, most recently from b9ad783 to 356083d Compare November 27, 2024 14:10
valpinkman
valpinkman previously approved these changes Nov 28, 2024
LucasWerey
LucasWerey previously approved these changes Nov 28, 2024
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 please make sure you/QA tests the sync onboarding on LLM+LLD for both seeded & unseeded devices 🙏

aussedatlo
aussedatlo previously approved these changes Nov 28, 2024
@jiyuzhuang jiyuzhuang merged commit f15fdd3 into develop Nov 29, 2024
55 checks passed
@jiyuzhuang jiyuzhuang deleted the feat/protect-3455-remove-ff branch November 29, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants