-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROTECT-3455] Remove feature_recover_upsell_redirection feature flag from codebase #8503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
live-github-bot
bot
added
desktop
Has changes in LLD
mobile
Has changes in LLM
common
Has changes in live-common
ledgerjs
Has changes in the ledgerjs open source libs
labels
Nov 27, 2024
jiyuzhuang
force-pushed
the
feat/protect-3455-remove-ff
branch
2 times, most recently
from
November 27, 2024 14:10
b9ad783
to
356083d
Compare
valpinkman
previously approved these changes
Nov 28, 2024
LucasWerey
previously approved these changes
Nov 28, 2024
ofreyssinet-ledger
previously approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 please make sure you/QA tests the sync onboarding on LLM+LLD for both seeded & unseeded devices 🙏
aussedatlo
previously approved these changes
Nov 28, 2024
jiyuzhuang
force-pushed
the
feat/protect-3455-remove-ff
branch
from
November 28, 2024 14:41
356083d
to
287e3be
Compare
jiyuzhuang
dismissed stale reviews from valpinkman, aussedatlo, LucasWerey, and ofreyssinet-ledger
via
November 28, 2024 14:53
b34f4c6
jiyuzhuang
force-pushed
the
feat/protect-3455-remove-ff
branch
2 times, most recently
from
November 28, 2024 14:54
b34f4c6
to
f2a8da7
Compare
jiyuzhuang
force-pushed
the
feat/protect-3455-remove-ff
branch
from
November 28, 2024 15:15
f2a8da7
to
322fd58
Compare
jiyuzhuang
requested review from
ofreyssinet-ledger,
aussedatlo and
valpinkman
November 29, 2024 08:48
ofreyssinet-ledger
approved these changes
Nov 29, 2024
LucasWerey
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.feature_recover_upsell_redirection
feature flag has been removed, now the new onboarding flow and redirections after onboarding will always take place.📝 Description
feature_recover_upsell_redirection
feature flag has been removed, now the new onboarding flow and redirections after onboarding will always take place.`
BackupStep
components for both LLD and LLM are not used in any other place, so they have been removed.❓ Context
🧐 Checklist for the PR Reviewers