Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if returnTo is defined (release) #8518

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Couto
Copy link
Contributor

@Couto Couto commented Nov 28, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Check if returnTo is defined as a string before triggering the swap analytic.
Some sections of the application do not provide a returnTo value.

Screen.Recording.2024-11-28.at.08.57.16.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

* fix: check if returnTo is defined
* chore: add changeset
* chore: accept suggestion
@Couto Couto requested a review from a team as a code owner November 28, 2024 09:30
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 28, 2024 9:30am
native-ui-storybook ⬜️ Ignored (Inspect) Nov 28, 2024 9:30am
react-ui-storybook ⬜️ Ignored (Inspect) Nov 28, 2024 9:30am
web-tools ⬜️ Ignored (Inspect) Nov 28, 2024 9:30am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 28, 2024
@live-github-bot
Copy link
Contributor

Desktop Bundle Checks

Comparing cc3cff5 against 6d679f5.

🚀 renderer bundle size decreased (38.3mb -> 37.4mb). Thanks ❤️
⚠️ @ethersproject/abi library is now duplicated in renderer (regression)
⚠️ readable-stream library is now duplicated in renderer (regression)
⚠️ safe-buffer library is now duplicated in renderer (regression)
⚠️ eth-lib/lib/hash library is now duplicated in renderer (regression)
⚠️ fp-ts/lib/Either library is now duplicated in renderer (regression)
⚠️ ethereumjs-util library is now duplicated in renderer (regression)
⚠️ io-ts library is now duplicated in renderer (regression)
⚠️ @celo/connect/lib/utils/formatter library is now duplicated in renderer (regression)
⚠️ @celo/wallet-base library is now duplicated in renderer (regression)
⚠️ multibase library is now duplicated in renderer (regression)
⚠️ multicodec library is now duplicated in renderer (regression)
⚠️ isarray library is now duplicated in renderer (regression)
⚠️ eth-lib/lib/bytes library is now duplicated in renderer (regression)
🚀 ethereum-cryptography/secp256k1 library is no longer duplicated in renderer
🚀 @noble/hashes/_assert library is no longer duplicated in renderer
🚀 @ethereumjs/rlp library is no longer duplicated in renderer
🚀 ethereum-cryptography/keccak library is no longer duplicated in renderer
🚀 ethereum-cryptography/utils library is no longer duplicated in renderer
🚀 @ethereumjs/util library is no longer duplicated in renderer
🚀 cross-fetch library is no longer duplicated in renderer

@Couto Couto merged commit 9cea8d5 into release Nov 28, 2024
41 checks passed
@Couto Couto deleted the fix/returnTo-undefined-release branch November 28, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants