Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add another ledger solana validator #8563

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Dec 2, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

The PTX team would like to add a validator displayed by default in the delegate screen.
But no validator should be selected by default.

demo.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested review from a team as code owners December 2, 2024 12:20
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 2, 2024 2:31pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:31pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:31pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:31pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common translations Translation files have been touched labels Dec 2, 2024
ComradeAERGO
ComradeAERGO previously approved these changes Dec 2, 2024
@Canestin Canestin merged commit 93f8f78 into develop Dec 2, 2024
53 of 55 checks passed
@Canestin Canestin deleted the LIVE-14413-add-solana-validator branch December 2, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants