Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #8581 from LedgerHQ/fix/LIVE-15154 #8586

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

themooneer
Copy link
Contributor

@themooneer themooneer commented Dec 3, 2024

fix: Move ICP memo tag field on recepient step when FF lldMemoTag is ON

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Same PR as #8581

❓ Context

  • JIRA or GitHub link:

https://ledgerhq.atlassian.net/browse/LIVE-15154


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

fix: Move ICP memo tag field on recepient step when FF lldMemoTag is ON
@themooneer themooneer requested review from a team as code owners December 3, 2024 16:08
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 4:09pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 4:09pm
react-ui-storybook ⬜️ Ignored (Inspect) Dec 3, 2024 4:09pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 4:09pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 3, 2024
@themooneer themooneer merged commit 87d298c into release Dec 4, 2024
51 of 55 checks passed
@themooneer themooneer deleted the fix/LIVE-15142-for-release branch December 4, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants