Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add mev protection on swap #8596

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Dec 4, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

This PR fixes this one adding mev protection for broadcasting. An issue where transactions were not being processed through Blink when MEV Protected was activated during an ETH swap.

Steps to Reproduce

  1. Ensure that the MEV Protected feature is activated for a user.
  2. Initiate a swap of ETH funds.

Expected Behavior

The transaction should be processed through Blink.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested a review from a team as a code owner December 4, 2024 10:25
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 4, 2024 10:25am
native-ui-storybook ⬜️ Ignored (Inspect) Dec 4, 2024 10:25am
react-ui-storybook ⬜️ Ignored (Inspect) Dec 4, 2024 10:25am
web-tools ⬜️ Ignored (Inspect) Dec 4, 2024 10:25am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 4, 2024
@Canestin Canestin changed the title chore(prerelease) update cryptoassets @Canestin bugfix: add mev protection on swap Dec 4, 2024
@Canestin Canestin changed the title @Canestin bugfix: add mev protection on swap bugfix: add mev protection on swap Dec 4, 2024
@Canestin Canestin merged commit 40509e4 into release Dec 4, 2024
30 of 38 checks passed
@Canestin Canestin deleted the LIVE-15149-mev-protection-on-swap branch December 4, 2024 10:26
@Canestin Canestin restored the LIVE-15149-mev-protection-on-swap branch December 5, 2024 10:54
ThatOneCalculator pushed a commit to ThatOneCalculator/ledger-live that referenced this pull request Jan 6, 2025
@jprudent jprudent mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant