Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: LIVE-3199 - LLM - Receive flow fix isue on receive from market page #897

Merged

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Aug 10, 2022

πŸ“ Description

Fixes issue while receiving tokens from market page.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-3199

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Aug 10, 2022 at 1:26PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 10, 2022 at 1:26PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Aug 10, 2022 at 1:26PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Aug 10, 2022 at 1:26PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

πŸ¦‹ Changeset detected

Latest commit: bb92400

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #897 (deec703) into release (5fd9448) will not change coverage.
The diff coverage is n/a.

❗ Current head deec703 differs from pull request most recent head bb92400. Consider uploading reports for the commit bb92400 to get more accurate results

@@           Coverage Diff            @@
##           release     #897   +/-   ##
========================================
  Coverage    47.50%   47.50%           
========================================
  Files          623      623           
  Lines        27751    27751           
  Branches      7160     7160           
========================================
  Hits         13182    13182           
  Misses       13447    13447           
  Partials      1122     1122           
Flag Coverage Ξ”
test 47.50% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

@LFBarreto

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
undefined undefined trace
undefined undefined trace

@LFBarreto LFBarreto merged commit 4172e47 into release Aug 10, 2022
@LFBarreto LFBarreto deleted the bugfix/LIVE-3199-llm-receive-flow-token-market-issue branch August 10, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants