bugfix/LIVE-3322-back-to-edit-fees #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 6065c3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
desktop
Codecov ReportBase: 48.17% // Head: 47.92% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #908 +/- ##
===========================================
- Coverage 48.17% 47.92% -0.25%
===========================================
Files 685 620 -65
Lines 30011 27870 -2141
Branches 7822 7174 -648
===========================================
- Hits 14458 13358 -1100
+ Misses 15498 14454 -1044
- Partials 55 58 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
|
@henrily-ledger Screenshots: β
It seems this PR contains screenshots that are different from the base branch.
windows
|
hedi-edelbloute
approved these changes
Aug 11, 2022
apps/ledger-live-desktop/src/renderer/components/Modal/ModalHeader.jsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/modals/SignTransaction/Body.jsx
Outdated
Show resolved
Hide resolved
|
|
|
/generate-screenshots |
henri-ly
force-pushed
the
bugfix/LIVE-3322-back-to-edit-fees
branch
from
06c8979 to
dbc9705
Compare
|
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
adjust text and remove console.log update screenshots (ubuntu-latest) update screenshots (windows-latest) update screenshots (macos-latest) Smartling translations are completed for PR#908 from bugfix/LIVE-3322-back-to-edit-fees (#1080) * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ru-RU locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to de-DE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ko-KR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to pt-BR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to es-ES locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to tr-TR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ar-AE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to fr-FR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to zh-CN locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ja-JP locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ru-RU locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to de-DE locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ko-KR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to pt-BR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to es-ES locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to tr-TR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ar-AE locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to fr-FR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to zh-CN locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ja-JP locale Revert "update screenshots (windows-latest)" This reverts commit 68ff4e473209618040723253885e78dde3e109b9. Revert "update screenshots (ubuntu-latest)" This reverts commit e37df600fa947ee6ab4998e79c7ce96ab88f481b. Revert "update screenshots (macos-latest)" This reverts commit 9a15ace50e9b1bc4a27db16335b5c19e4c8e10c1. update screenshot Revert "Smartling translations are completed for PR#908 from bugfix/LIVE-3322-back-to-edit-fees (#1080)" This reverts commit 8d992be74a46ef66e5449d311f3164e1f1b08031. Smartling update
henri-ly
force-pushed
the
bugfix/LIVE-3322-back-to-edit-fees
branch
from
e8f19f6 to
6065c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
Change in modal sign transaction to make more visible the changeFees
β Context
live-desktophttps://ledgerhq.atlassian.net/browse/LIVE-3322β Checklist
πΈ Demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.