Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/typos Fixes bad wording in language files #961

Merged
merged 5 commits into from
Aug 18, 2022
Merged

Conversation

juan-cortes
Copy link
Contributor

πŸ“ Description

Found a small typo while developing something else, decided to do a run down of our language files and found a few more.

❓ Context

  • Impacted projects: ledger-live-desktop, ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-3374

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

No demo

πŸš€ Expectations to reach

Only wording

@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Aug 17, 2022 at 4:25PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 17, 2022 at 4:25PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Aug 17, 2022 at 4:25PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Aug 17, 2022 at 4:25PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022

πŸ¦‹ Changeset detected

Latest commit: 789223d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
ledger-live-desktop Minor
live-mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Aug 17, 2022
@@ -0,0 +1,5 @@
---
"ledger-live-desktop": minor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super unimportant but I think these changes are more of a patch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ah: you're probably right

@@ -1283,7 +1283,7 @@
"noSearchResults": "Sorry, we did not find any search results.",
"retrySearchKeyword": "Please retry the search with another keyword.",
"retrySearchParams": "Please retry the search with another parameters.",
"trackFavAssets": "Track your favourite",
"trackFavAssets": "Track your favorite",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both are fine :D American vs british english

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We settled for american for all

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #961 (54eaf13) into develop (68c50cd) will increase coverage by 0.49%.
The diff coverage is n/a.

❗ Current head 54eaf13 differs from pull request most recent head 789223d. Consider uploading reports for the commit 789223d to get more accurate results

@@             Coverage Diff             @@
##           develop     #961      +/-   ##
===========================================
+ Coverage    47.43%   47.92%   +0.49%     
===========================================
  Files          601      620      +19     
  Lines        27275    27870     +595     
  Branches      7088     7174      +86     
===========================================
+ Hits         12937    13358     +421     
- Misses       14284    14454     +170     
- Partials        54       58       +4     
Flag Coverage Ξ”
test 47.92% <ΓΈ> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/cryptoassets/data/trc20.js 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/errors/src/helpers.ts 25.00% <0.00%> (ΓΈ)
...ibs/ledgerjs/packages/cryptoassets/data/stellar.js 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/cryptoassets/src/fiats.ts 100.00% <0.00%> (ΓΈ)
...hw-transport-mocker/src/createTransportRecorder.ts 13.04% <0.00%> (ΓΈ)
libs/ledgerjs/packages/cryptoassets/data/erc20.js 100.00% <0.00%> (ΓΈ)
...hw-transport-mocker/src/createTransportReplayer.ts 13.79% <0.00%> (ΓΈ)
libs/ledgerjs/packages/cryptoassets/data/asa.js 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/cryptoassets/data/esdt.js 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/errors/src/index.ts 78.41% <0.00%> (ΓΈ)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 17, 2022

@juan-cortes

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice! good catches πŸ‘

Copy link
Contributor

@elbywan elbywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because 3 approvals is not enough πŸ‘Œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants