-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/typos Fixes bad wording in language files #961
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 789223d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -0,0 +1,5 @@ | |||
--- | |||
"ledger-live-desktop": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super unimportant but I think these changes are more of a patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:ah: you're probably right
@@ -1283,7 +1283,7 @@ | |||
"noSearchResults": "Sorry, we did not find any search results.", | |||
"retrySearchKeyword": "Please retry the search with another keyword.", | |||
"retrySearchParams": "Please retry the search with another parameters.", | |||
"trackFavAssets": "Track your favourite", | |||
"trackFavAssets": "Track your favorite", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both are fine :D American vs british english
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We settled for american for all
Codecov Report
@@ Coverage Diff @@
## develop #961 +/- ##
===========================================
+ Coverage 47.43% 47.92% +0.49%
===========================================
Files 601 620 +19
Lines 27275 27870 +595
Branches 7088 7174 +86
===========================================
+ Hits 12937 13358 +421
- Misses 14284 14454 +170
- Partials 54 58 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice! good catches π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because 3 approvals is not enough π
π Description
Found a small typo while developing something else, decided to do a run down of our language files and found a few more.
β Context
ledger-live-desktop, ledger-live-mobile
https://ledgerhq.atlassian.net/browse/LIVE-3374
β Checklist
πΈ Demo
No demo
π Expectations to reach
Only wording