Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Add Speculos Http API transport #746

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Add Speculos Http API transport #746

merged 2 commits into from
Jan 4, 2022

Conversation

r4mmer
Copy link
Contributor

@r4mmer r4mmer commented Dec 27, 2021

I just added a package similar to speculos transport but using the http api instead of the tcp ports

@r4mmer r4mmer requested a review from a team as a code owner December 27, 2021 14:11
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a README.md and run yarn doc

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #746 (69ab06a) into master (9fb8393) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
- Coverage   45.03%   44.60%   -0.44%     
==========================================
  Files          82       83       +1     
  Lines        4965     5013      +48     
  Branches      819      819              
==========================================
  Hits         2236     2236              
- Misses       2712     2760      +48     
  Partials       17       17              
Impacted Files Coverage Δ
...rt-node-speculos-http/src/SpeculosHttpTransport.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb8393...69ab06a. Read the comment docs.

@r4mmer
Copy link
Contributor Author

r4mmer commented Jan 3, 2022

please add a README.md and run yarn doc

Done!

@r4mmer r4mmer requested review from gre and removed request for a team January 3, 2022 17:12
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@gre gre merged commit 73297d8 into LedgerHQ:master Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants