This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Rework hw-app-eth to split out "ledger services" from the app logic #747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
becomes deprecated in favor of
where resolution is an object with following shape:
This object contains all the hex serialized data the device may need to clear sign information on device screen.
Hopefully we also provide a default "service" to resolve this data, example:
This allows us to decouple the transaction resolution from the device signature logic itself in order for you to have better control and for more usecases
.catch(() => null)
in the snippet above