Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Use ethersproject packages intead of ethers umbrella package #763

Merged

Conversation

FrederikBolding
Copy link
Contributor

Using the ethersproject packages instead of the huge ethers umbrella package reduces the amount of dependencies bundled with LedgerJS. Would recommend doing this 👍

@FrederikBolding FrederikBolding requested a review from a team as a code owner January 13, 2022 12:23
@FrederikBolding FrederikBolding changed the title Use ethersproject packages intead of umbrella package Use ethersproject packages intead of ethers umbrella package Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #763 (5500742) into master (6b78677) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   43.56%   43.55%   -0.02%     
==========================================
  Files          81       81              
  Lines        4823     4822       -1     
  Branches      791      791              
==========================================
- Hits         2101     2100       -1     
  Misses       2708     2708              
  Partials       14       14              
Impacted Files Coverage Δ
packages/hw-app-eth/src/utils.ts 90.90% <100.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b78677...5500742. Read the comment docs.

@FrederikBolding FrederikBolding force-pushed the use-ethersproject-instead-of-umbrella-pkg branch from 7fbb592 to 5500742 Compare January 14, 2022 13:14
@gre gre merged commit 199e381 into LedgerHQ:master Jan 14, 2022
@FrederikBolding FrederikBolding deleted the use-ethersproject-instead-of-umbrella-pkg branch January 14, 2022 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants