This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
LL-8941 Conditionally auto disconnect the node-hid-singleton #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the second attempt at getting a automatic release of the node-hid-singleton. After the talk we had the other day @gre I think that by exposing this method
setAllowAutoDisconnect
at the transport level and allowing it to override the auto-disconnect (basically re-scheduling it again) will allow us to calltransport.setAllowAutoDisconnect(false)
at the begining of thewithDevice
implementation onhw/deviceAccess
from live-common and unsetting the flag on theonClose
for the transport, we essentially bypass the problem we have of long running tasks inside awithDevice
instance.What do you think?