Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

[@ledgerHQ/hw-app-helium] switch to use @helium/address #805

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

allenan
Copy link
Contributor

@allenan allenan commented Mar 2, 2022

This uses a simplified, common @helium/address package which has been extracted from our two crypto packages, @helium/crypto and @helium/crypto-react-native. This will allow @ledgerHQ/hw-app-helium to be used on both react native and nodejs. Currently it will only work on nodejs.

@allenan allenan requested a review from a team as a code owner March 2, 2022 20:44
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #805 (27164fe) into master (1ec099d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   45.09%   45.09%           
=======================================
  Files          83       83           
  Lines        5060     5060           
  Branches      897      897           
=======================================
  Hits         2282     2282           
  Misses       2576     2576           
  Partials      202      202           
Impacted Files Coverage Δ
packages/hw-app-helium/src/serialization.ts 92.06% <ø> (ø)
packages/hw-app-helium/src/Helium.ts 89.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec099d...27164fe. Read the comment docs.

@gre gre merged commit 29d607a into LedgerHQ:master Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants