Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Permalink with URL in partials/paginator #176

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

mandarvaze
Copy link
Contributor

Fixes #172

@Lednerb
Copy link
Owner

Lednerb commented Jun 5, 2019

Thank you for your contribution! 👍

@Lednerb
Copy link
Owner

Lednerb commented Jun 5, 2019

@mandarvaze
Does this bump the minimum required hugo version?

If so, please update the README.md for this.

@mandarvaze
Copy link
Contributor Author

@Lednerb My change only fixes the "build" error. I'm not sure I understand how to test the paginator functionality itself.

Also, I don't know when the .Paginator.Prev.Permalink was deprecated (as mentioned by @lingej in #172)
I checked release documents and searched thru gohugo code, but could not find that out myself.

@Lednerb Lednerb merged commit e4c85d8 into Lednerb:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error paginator
2 participants