Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New option for video content: play directly mp4 video #218

Merged
merged 1 commit into from
Jun 11, 2020
Merged

New option for video content: play directly mp4 video #218

merged 1 commit into from
Jun 11, 2020

Conversation

frigi83
Copy link
Contributor

@frigi83 frigi83 commented Jun 11, 2020

I have added two new parameters for the video content. They allow to play directly a mp4 file (locally or remote), using the video HTML tag.

  • mp4video: the path to mp4 video file
  • mp4videoImage: poster image for the video (optional)

If mp4videoImage exist it well be used for the Open Graph tag og:image.

Lednerb
Lednerb approved these changes Jun 11, 2020
View reviewed changes
Copy link
Owner

@Lednerb Lednerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 👍

It's also a needed and good re-write of the baseof.html parameters section!

@Lednerb Lednerb merged commit 9fd20a3 into Lednerb:master Jun 11, 2020
@Lednerb
Copy link
Owner

Lednerb commented Jun 11, 2020

Please feel free to add yourself to the contributers list if you like to 😉
https://github.com/Lednerb/bilberry-hugo-theme#Contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lednerb Lednerb Lednerb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frigi83 @Lednerb