Fixing issue #38 AttributeError 'NoneType' object has no attribute 'json_string' #41
Conversation
Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438 Here is the change commit to fix the vuln in Quill slab/quill#2439 The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab
Resolves issue [LeeHanYeong#33](LeeHanYeong#33)
|
@LeeHanYeong do you want to drop support for django 3.0.x in favor of django 3.1.x to support the |
|
this was already fixed in #36, which also has the backwards-compatible version based on TextField. also, 3.0 is being dropped by django in a few months: https://www.djangoproject.com/download/#supported-versions |
|
ah, thanks @void-witch. Sounds like the way is forward! @LeeHanYeong can we merge and increment the version of the project? I got it to work with https://github.com/LeeHanYeong/django-quill-editor-sample after updating the sample to django 3.1.x. Is there a better way for the sample and tests to merge into one repo? |
|
@cdesch It is better to drop support for django 3.0, which is being discontinued. |
…son_string' (#41) * Bump to Quill Version 1.3.7 Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438 Here is the change commit to fix the vuln in Quill slab/quill#2439 The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab * Adding JS/CSS include instructions from README.md Resolves issue [#33](#33) * adding None return for json_string
Related issue #38 and fixes the issue of json
This PR and PR#36 are breaking changes for Django Versions < 3.1.x
The JSONField was introduced in Django 3.1. django-quill-editor will have to drop support for django 3.0.x versions.