Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get slug from problem list for a new option of filename in English. #725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

assumecs
Copy link

@assumecs assumecs commented Jul 29, 2021

Depends on Provide an English filename when using Endpoint Translation

This might be a better way than #724

Copy link
Contributor

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -234,6 +234,8 @@ async function resolveRelativePath(relativePath: string, node: IProblem, selecte
return node.id;
case "name":
return node.name;
case "slug":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to think for a better name of this new placeholder, slug is not straightforward to me at least...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got me...
I don't know what slug means in problem list.
Maybe name_en?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this What is a “slug” in Django:it is created from the title by down-casing all letters, and replacing spaces by hyphens-.
It's not easy to find a word to replace "slug", "short-label"?"kebab-case-title"? or just "slug"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I like the idea to provide English name as the file name. But there is one problem: people might ask 'Ok, we have the slug styled name, so what about the camel case/pascal case/snake case'?

I think (maybe) a better solution here is having a setting to specify whether to use translated name as the file name, and then, we can provide different style option to the user(kebab, snake, pascal, ...)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants