Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSSAid not appearing when trying to share #50

Closed
oliroe opened this issue Jun 10, 2024 · 30 comments
Closed

RSSAid not appearing when trying to share #50

oliroe opened this issue Jun 10, 2024 · 30 comments
Labels
bug Something isn't working
Milestone

Comments

@oliroe
Copy link

oliroe commented Jun 10, 2024

In version 1.6.5 if I was on GitHub on Chrome I could click share and share the webpage with RSSAid which would show the available RSS feeds. Version 2.0.1 does not appear

I have uninstalled 2.0.1 and installed 1.6.5 and it becomes selectable again so there's definitely an issue with the latest version

@oliroe
Copy link
Author

oliroe commented Jun 10, 2024

Screenshot_20240610-204210.png

Could it be the removal of the SEND intent?

@LeetaoGoooo
Copy link
Owner

LeetaoGoooo commented Jun 10, 2024 via email

@LeetaoGoooo LeetaoGoooo added the bug Something isn't working label Jun 11, 2024
@LeetaoGoooo LeetaoGoooo added this to the v2.0.2 milestone Jun 20, 2024
LeetaoGoooo added a commit that referenced this issue Jul 17, 2024
@LeetaoGoooo
Copy link
Owner

Screenshot_20240610-204210.png

Could it be the removal of the SEND intent?

Sorry for the delay in fixing this. I've recovered the code. Please let me know if it works

@oliroe
Copy link
Author

oliroe commented Jul 17, 2024

Screenshot_20240717-121442

Screenshot_20240717-115836

Sorry, i was mid way through writing my reply. The new version now appear when you try and share the link but it doesn't bring the details through to the app. I've included a screenshot of 1.65 showing the difference

@LeetaoGoooo
Copy link
Owner

Screenshot_20240717-115836

thanks man~~

@oliroe
Copy link
Author

oliroe commented Jul 17, 2024

Sorry, was part way through editing my reply. It's partially fixed in that it now appears in the share menu but it doesn't bring the details of the link through

@LeetaoGoooo LeetaoGoooo reopened this Jul 17, 2024
@LeetaoGoooo
Copy link
Owner

Sorry, was part way through editing my reply. It's partially fixed in that it now appears in the share menu but it doesn't bring the details of the link through

Yeah, you're right. Let me reopen this issue and then look into this problem.

@LeetaoGoooo
Copy link
Owner

Sorry, was part way through editing my reply. It's partially fixed in that it now appears in the share menu but it doesn't bring the details of the link through

new version is released and now you can see link preview in app

@oliroe
Copy link
Author

oliroe commented Jul 18, 2024

Just letting you know this hasn't resolved it for me. I've cleared cache and removed all versions of the app and started again with 2.0.2. If i share a link to the app the preview isn't shown as it did with 1.6.5

@LeetaoGoooo
Copy link
Owner

Just letting you know this hasn't resolved it for me. I've cleared cache and removed all versions of the app and started again with 2.0.2. If i share a link to the app the preview isn't shown as it did with 1.6.5

yeah,you're right. I just replaced the previous preview link component with a new one,so it looks like a little different from before. And then I will add new theme for rssaid

@oliroe
Copy link
Author

oliroe commented Jul 22, 2024

Given this issue is now closed would you like me to open another one?

@LeetaoGoooo LeetaoGoooo reopened this Jul 22, 2024
@LeetaoGoooo
Copy link
Owner

LeetaoGoooo commented Jul 22, 2024

Given this issue is now closed would you like me to open another one?

I just reopen this issue. Have you tried the latest version 3.0.0 ? There are a new ui for the RSSAid and also for the preview link.

Simulator Screenshot - iPhone 15 - 2024-07-23 at 06 49 19

@oliroe
Copy link
Author

oliroe commented Jul 23, 2024

Screenshot_20240723-095523.png

Hi

Whenever I share a link on stock Android 14 I see the above, it doesn't include the link address and just opens the app. This is using 3.0.0

@LeetaoGoooo
Copy link
Owner

Screenshot_20240723-095523.png

Hi

Whenever I share a link on stock Android 14 I see the above, it doesn't include the link address and just opens the app. This is using 3.0.0

can you see the rules in the config page?

@LeetaoGoooo
Copy link
Owner

LeetaoGoooo commented Jul 23, 2024 via email

@oliroe
Copy link
Author

oliroe commented Jul 23, 2024

Screenshot_20240723-140321.png

Screenshot_20240723-140309.png

Interestingly if I copy the link from my clipboard it doesn't work either. The rules seem to be populated ok

@LeetaoGoooo
Copy link
Owner

Screenshot_20240723-140321.png

Screenshot_20240723-140309.png

Interestingly if I copy the link from my clipboard it doesn't work either. The rules seem to be populated ok

According to the rules in the screenshot,it seems that application still contains the previous rules. It should be a bug,let me fix it tomorrow.

Right now you can just delete the application and install it again,then it should work 🤣

@LeetaoGoooo
Copy link
Owner

also make a new release to fix this v3.0.1

@oliroe
Copy link
Author

oliroe commented Jul 23, 2024

Feel free to tell me to go away and stop bothering you 😀

I've cleared the memory and cache of the app, uninstalled it and installed the new release. Now the rules are blank and do not refresh (stays blank). Using the URL of my local instance which is accessible in the browser

@LeetaoGoooo
Copy link
Owner

LeetaoGoooo commented Jul 23, 2024 via email

@oliroe
Copy link
Author

oliroe commented Jul 23, 2024

My instance of rsshub is updated daily and I don't use an access key. I can't get any version since 1.6.5 to bring back the rules.

Looks like I'm the only one with the problem though

@LeetaoGoooo
Copy link
Owner

My instance of rsshub is updated daily and I don't use an access key. I can't get any version since 1.6.5 to bring back the rules.

Looks like I'm the only one with the problem though

emmm could you try to set domain to https://rsshub.app in the config and then refresh the rules using v3.0.1 version, which i released last night~ Meanwhile try to access your domain/api/radar/rules to see if the rules are returned in this end-point. check with https://docs.rsshub.app/guide/api

@oliroe
Copy link
Author

oliroe commented Jul 23, 2024

Clean install of 3.0.1

Using the default URL doesn't bring back the rules.

Mydomain/api/radar/rules in chrome brings back all the rules

@LeetaoGoooo
Copy link
Owner

I know why now. I made a very silly mistake, and I'm currently building the new version. I removed the internet permission from Android.

@LeetaoGoooo
Copy link
Owner

@oliroe
Copy link
Author

oliroe commented Jul 23, 2024

Ok, rules are now pulled back which is great.
Pasting a link now brings back the feed options

Sharing a link with the app still doesn't pull through the link into the app though

@LeetaoGoooo
Copy link
Owner

Ok, rules are now pulled back which is great.
Pasting a link now brings back the feed options

Sharing a link with the app still doesn't pull through the link into the app though

Haha, regardless, I have partially fixed this issue. As for the other problem, I’ll look into it carefully today and fix it as soon as possible.

Also,I'm really appreciate your patience

@LeetaoGoooo
Copy link
Owner

iShot_2024-07-24_09.45.29.mp4

for the v3.0.1+11, i think share event is also fixed~~

@oliroe
Copy link
Author

oliroe commented Jul 24, 2024

Done a quick test and all seems to be working now 😀

Appreciate the perseverance

@LeetaoGoooo
Copy link
Owner

Done a quick test and all seems to be working now 😀

Appreciate the perseverance

niceeee~~ i'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants