feat(progress-bar): new components #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owensgit
requested changes
Jun 10, 2024
There was a problem hiding this comment.
Great work @jaynguyenslng and a really good first big contribution to Canopy 🙌
I've added a lot of comments, but most of them are quite small. Please shout if you want to discuss anything in detail, esp. the a11y points.
projects/canopy/src/lib/progress-indicator/docs/guide.stories.mdx
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-indicator.module.ts
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-journey/progress-journey.component.html
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-bar/progress-bar.component.html
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-journey/progress-journey.component.ts
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-indicator.component.html
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-indicator.component.html
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-indicator.component.html
Outdated
Show resolved
Hide resolved
pauleustice
reviewed
Jun 12, 2024
projects/canopy/src/lib/progress-indicator/progress-bar/progress-bar.component.ts
Outdated
Show resolved
Hide resolved
pauleustice
reviewed
Jun 12, 2024
projects/canopy/src/lib/progress-indicator/progress-indicator.component.ts
Outdated
Show resolved
Hide resolved
owensgit
requested changes
Jun 13, 2024
There was a problem hiding this comment.
Thanks @jaynguyenslng, great work! Just a few more very small comments from me.
projects/canopy/src/lib/progress-indicator/progress-indicator.interface.ts
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/docs/guide.stories.mdx
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-bar/progress-bar.component.scss
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-bar/progress-bar.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-bar/progress-bar.component.spec.ts
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-bar/progress-bar.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-indicator.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-indicator.component.ts
Outdated
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-indicator.component.spec.ts
Show resolved
Hide resolved
projects/canopy/src/lib/progress-indicator/progress-indicator.module.ts
Outdated
Show resolved
Hide resolved
owensgit
requested changes
Jun 17, 2024
projects/canopy/src/lib/progress-indicator/progress-indicator.component.spec.ts
Show resolved
Hide resolved
owensgit
previously approved these changes
Jun 17, 2024
ashB100
approved these changes
Jun 20, 2024
|
🎉 This PR is included in version 11.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an new progress indicator component.
Ticket: https://legalandgeneral.atlassian.net/browse/WPD-4440
Discussion: #1407
Screenshot:
Requirements
Please briefly outline any requirements for the work which may aid the testing and review process.
Design link: (link to design or delete if not required)
Checklist: