Allow rendering into the document.body #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When possible, its good to use the shallow rendering (less overhead).
Other times, we use full jsdom, but only to render into a document fragment (the default for React tests).
I've had some use cases where I actually benefited from rendering into the actual document.body of the jsdom instance.
For example, you can't always avoid using a jquery plugin, and it's easier to test these integrations in an actual body element. Its more overhead, but it's still way way less than running something like selenium / webdriver.
The test I added should demonstrate the API. Basically, its just a new flag, and everything else works as normal, except that you need to call
.clean()
at the end of the test.