Fix phpstan errors

LeikoDmitry · Nov 20, 2023 · 8defdf6 · 8defdf6
1 parent dc1e9d4
commit 8defdf6
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 14 deletions.
diff --git a/src/Listener/ApiExceptionListener.php b/src/Listener/ApiExceptionListener.php
@@ -17,9 +17,9 @@ class ApiExceptionListener
 {
     public function __construct(
         private readonly ExceptionMappingResolver $exceptionMappingResolver,
-        private readonly LoggerInterface          $logger,
-        private readonly SerializerInterface      $serializer,
-        private readonly bool                     $isDebug,
+        private readonly LoggerInterface $logger,
+        private readonly SerializerInterface $serializer,
+        private readonly bool $isDebug,
     ) {
     }
 
@@ -43,7 +43,7 @@ public function __invoke(ExceptionEvent $exceptionEvent): void
         }
 
         $message = $mapping->isHidden() ? Response::$statusTexts[$mapping->getCode()] : $throwable->getMessage();
-        $details = $this->isDebug && !$mapping->isLoggable() ? new ErrorDebugDetails($throwable->getTraceAsString()): null;
+        $details = $this->isDebug && !$mapping->isLoggable() ? new ErrorDebugDetails($throwable->getTraceAsString()) : null;
 
         $data = $this->serializer->serialize(data: new ErrorResponse($message, $details), format: JsonEncoder::FORMAT);
 

diff --git a/src/Model/ErrorResponse.php b/src/Model/ErrorResponse.php
@@ -4,7 +4,6 @@
 
 use Nelmio\ApiDocBundle\Annotation\Model;
 use OpenApi\Annotations as OA;
-use App\Model\ErrorDebugDetails;
 
 readonly class ErrorResponse
 {

diff --git a/tests/Controller/SubscriberControllerTest.php b/tests/Controller/SubscriberControllerTest.php
@@ -7,7 +7,7 @@
 
 class SubscriberControllerTest extends AbstractControllerTestCase
 {
-    public function testSubscribe()
+    public function testSubscribe(): void
     {
         $this->kernelBrowser->request(
             method: 'POST',
@@ -18,7 +18,7 @@ public function testSubscribe()
         $this->assertResponseIsSuccessful();
     }
 
-    public function testSubscribeNotAgreed()
+    public function testSubscribeNotAgreed(): void
     {
         $this->kernelBrowser->request(
             method: 'POST',
@@ -35,7 +35,7 @@ public function testSubscribeNotAgreed()
                 PHP_EOL,
                 PHP_EOL
             ),
-            '$.details' => null
+            '$.details' => null,
         ]);
     }
 }
diff --git a/tests/Service/SubscriberServiceTest.php b/tests/Service/SubscriberServiceTest.php
@@ -29,30 +29,30 @@ protected function setUp(): void
     }
 
     public function testSubscribeAlreadyExist(): void
-	{
+    {
         $this->expectException(SubscriberFoundException::class);
 
-        $this->subscriberRepository->expects($this->once())
+        $this->subscriberRepository->expects($this->once()) /** @phpstan-ignore-line */
             ->method('findOneBy')
             ->with(['email' => static::EMAIL])
             ->willReturn((new Subscriber())->setEmail(static::EMAIL)->setId(1));
 
         (new SubscriberService($this->subscriberRepository, $this->entityManager))
             ->subscribe(new SubscriberRequest(email: static::EMAIL, agreed: false));
-	}
+    }
 
     public function testSubscribe(): void
     {
-        $this->subscriberRepository->expects($this->once())
+        $this->subscriberRepository->expects($this->once()) /** @phpstan-ignore-line */
             ->method('findOneBy')
             ->with(['email' => static::EMAIL])
             ->willReturn(null);
 
         $expectedSubscriber = new Subscriber();
         $expectedSubscriber->setEmail(static::EMAIL);
 
-        $this->entityManager->expects($this->once())->method('persist')->with($expectedSubscriber);
-        $this->entityManager->expects($this->once())->method('flush');
+        $this->entityManager->expects($this->once())->method('persist')->with($expectedSubscriber); /** @phpstan-ignore-line */
+        $this->entityManager->expects($this->once())->method('flush'); /** @phpstan-ignore-line */
 
         (new SubscriberService($this->subscriberRepository, $this->entityManager))
             ->subscribe(new SubscriberRequest(email: static::EMAIL, agreed: false));