Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minimal-blog): Add Canonical URL support #494

Merged
merged 3 commits into from
Sep 25, 2020
Merged

feat(minimal-blog): Add Canonical URL support #494

merged 3 commits into from
Sep 25, 2020

Conversation

aleccool213
Copy link
Contributor

@aleccool213 aleccool213 commented Sep 25, 2020 •
edited by LekoArts
Loading

Adds a canonicalUrl option to the frontmatter to set the respective meta tag to the <head />.

Fixes #493

LekoArts
LekoArts approved these changes Sep 25, 2020
View reviewed changes
Copy link
Owner

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added a Cypress test to verify this works in the future :)

@LekoArts LekoArts merged commit 0e9d7ac into LekoArts:master Sep 25, 2020
@LekoArts
Copy link
Owner 

Successfully published:
 - @lekoarts/gatsby-theme-minimal-blog-core@2.5.0
 - @lekoarts/gatsby-theme-minimal-blog@2.6.0

aleccool213
aleccool213 commented Sep 25, 2020
View reviewed changes
cypress/e2e/minimal-blog.ts
@@ -122,4 +122,8 @@ describe(`gatsby-theme-minimal-blog`, () => {
.should(`have.css`, `color`, `rgb(203, 213, 224)`)
.should(`have.css`, `background`, `rgb(26, 32, 44) none repeat scroll 0% 0% / auto padding-box border-box`)
})
it(`should accept canonical url in frontmatter and set in head`, () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-theme-minimal-blog]: Canonical URL support
2 participants
@aleccool213 @LekoArts