Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minimal-blog): Add Canonical URL support #494

Merged
merged 3 commits into from
Sep 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cypress/e2e/minimal-blog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,8 @@ describe(`gatsby-theme-minimal-blog`, () => {
.should(`have.css`, `color`, `rgb(203, 213, 224)`)
.should(`have.css`, `background`, `rgb(26, 32, 44) none repeat scroll 0% 0% / auto padding-box border-box`)
})
it(`should accept canonical url in frontmatter and set in head`, () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

cy.visit(`/curses-counter-curses-and-more`).waitForRouteChange()
cy.get(`head link[rel='canonical']`).should(`have.attr`, `href`, `https://random-blog-about-curses.com`)
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
title: "Curses and Counter-curses (Bewitch Your Friends and Befuddle Your Enemies with the Latest Revenges: Hair Loss, Jelly-Legs, Tongue-Tying, and Much, Much More)"
date: 2019-10-25
slug: "/curses-counter-curses-and-more"
canonicalUrl: "https://random-blog-about-curses.com"
---

Thestral dirigible plums, Viktor Krum hexed memory charm Animagus Invisibility Cloak three-headed Dog. Half-Blood Prince Invisibility Cloak cauldron cakes, hiya Harry! Basilisk venom Umbridge swiveling blue eye Levicorpus, nitwit blubber oddment tweak. Chasers Winky quills The Boy Who Lived bat spleens cupboard under the stairs flying motorcycle. Sirius Black Holyhead Harpies, you’ve got dirt on your nose. Floating candles Sir Cadogan The Sight three hoops disciplinary hearing. Grindlewald pig’s tail Sorcerer's Stone biting teacup. Side-along dragon-scale suits Filch 20 points, Mr. Potter.
Expand Down
3 changes: 3 additions & 0 deletions themes/gatsby-theme-minimal-blog-core/gatsby-node.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ exports.createSchemaCustomization = ({ actions, schema }, themeOptions) => {
tags: [PostTag]
banner: File @fileByRelativePath
description: String
canonicalUrl: String
}

type PostTag {
Expand All @@ -86,6 +87,7 @@ exports.createSchemaCustomization = ({ actions, schema }, themeOptions) => {
tags: [PostTag]
banner: File @fileByRelativePath
description: String
canonicalUrl: String
}

type MdxPage implements Node & Page {
Expand Down Expand Up @@ -195,6 +197,7 @@ exports.onCreateNode = ({ node, actions, getNode, createNodeId, createContentDig
tags: modifiedTags,
banner: node.frontmatter.banner,
description: node.frontmatter.description,
canonicalUrl: node.frontmatter.canonicalUrl,
}

const mdxPostId = createNodeId(`${node.id} >>> MdxPost`)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const query = graphql`
slug
}
description
canonicalUrl
body
excerpt
timeToRead
Expand Down
3 changes: 2 additions & 1 deletion themes/gatsby-theme-minimal-blog/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,11 @@ tags:
- Tutorial
- Dark Arts
banner: ./defence-against-the-dark-arts.jpg
canonicalUrl: https://random-blog-about-curses.com/curses-counter-curses-and-more
---
```

**The fields `description` and `banner` are optional!** If no description is provided, an excerpt of the blog post will be used. If no banner is provided, the default `siteImage` (from `siteMetadata`) is used.
**The fields `description`, `banner` and `canonicalUrl` are optional!** If no description is provided, an excerpt of the blog post will be used. If no banner is provided, the default `siteImage` (from `siteMetadata`) is used. If no `canonicalUrl` is provided, it will not be included in the header.

The `date` field has to be written in the format `YYYY-MM-DD`!

Expand Down
2 changes: 2 additions & 0 deletions themes/gatsby-theme-minimal-blog/src/components/post.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ type PostProps = {
slug: string
}[]
description?: string
canonicalUrl?: string
body: string
excerpt: string
timeToRead?: number
Expand All @@ -41,6 +42,7 @@ const Post = ({ data: { post } }: PostProps) => (
description={post.description ? post.description : post.excerpt}
image={post.banner ? post.banner.childImageSharp.resize.src : undefined}
pathname={post.slug}
canonicalUrl={post.canonicalUrl}
/>
<Heading variant="styles.h2">{post.title}</Heading>
<p sx={{ color: `secondary`, mt: 3, a: { color: `secondary` }, fontSize: [1, 1, 2] }}>
Expand Down
11 changes: 10 additions & 1 deletion themes/gatsby-theme-minimal-blog/src/components/seo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,17 @@ type SEOProps = {
pathname?: string
image?: string
children?: React.ReactNode
canonicalUrl?: string
}

const SEO = ({ title = ``, description = ``, pathname = ``, image = ``, children = null }: SEOProps) => {
const SEO = ({
title = ``,
description = ``,
pathname = ``,
image = ``,
children = null,
canonicalUrl = ``,
}: SEOProps) => {
const site = useSiteMetadata()

const {
Expand Down Expand Up @@ -52,6 +60,7 @@ const SEO = ({ title = ``, description = ``, pathname = ``, image = ``, children
<link rel="icon" type="image/png" sizes="32x32" href={withPrefix(`/favicon-32x32.png`)} />
<link rel="icon" type="image/png" sizes="16x16" href={withPrefix(`/favicon-16x16.png`)} />
<link rel="apple-touch-icon" sizes="180x180" href={withPrefix(`/apple-touch-icon.png`)} />
{canonicalUrl ? <link rel="canonical" href={canonicalUrl} /> : null}
{children}
</Helmet>
)
Expand Down