Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Socket.io (socketio) icons #311

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add Socket.io (socketio) icons #311

merged 2 commits into from
Jan 16, 2025

Conversation

arithefirst
Copy link
Contributor

Add New Icon(s)

Icon Details

Icon ID Icon
socketio-auto image
socketio-dark image
socketio-light image

Notes

  • Adds icons for Socket.io, which is a service that provides bidirectional and low-latency communication for every platform via websockets

Checklist

  • Added icon(s) to the appropriate directory
  • Updated documentation with the new icon(s)
  • Verified the icon(s) display correctly
  • If the icon has light and dark, verified the auto switch works correctly
  • The Svg does not contain any sort of strokes

Sorry, something went wrong.

Copy link
Contributor

@Tavish9 Tavish9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should remove strokes in the icons for compatibility.

@arithefirst
Copy link
Contributor Author

you should remove strokes in the icons for compatibility.

Completed, replaced with concentric circles.

@arithefirst arithefirst requested a review from Tavish9 January 5, 2025 21:45
Copy link
Contributor

@Tavish9 Tavish9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Could you please rebase to keep the history clean?

@arithefirst
Copy link
Contributor Author

Yep, gotchu
just give me one minute

Verified

This commit was signed with the committer’s verified signature.
arithefirst April Hall
Remove strokes for comptability
@arithefirst
Copy link
Contributor Author

Just, squashed, feel free to merge!

@arithefirst arithefirst requested a review from Tavish9 January 7, 2025 00:47
Copy link
Contributor

@Tavish9 Tavish9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

LelouchFR
LelouchFR previously approved these changes Jan 16, 2025
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@LelouchFR LelouchFR merged commit fe75c5b into LelouchFR:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants