New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing persistent storage for activity queue #50

Closed

golfinq wants to merge 1 commit into LemmyNet:main from golfinq:persistant-storage-3

golfinq commented Jun 23, 2023

This is a draft PR which attempts to address #31. There are still some TODOs and I am also looking for any feedback on the current method I am using

TODO:

Formatting
Prevent duplicates from being sent
Determine who should handle recovery after a crash, and how that should be done
Delete the Send Requests on disk after use
Log errors returned by the potential database interface as opposed to ignoring them
Actually test the code


          Outbound interface written

e32b407

Member

Nutomic commented Oct 24, 2023

The activity queue was removed in #75, closing this.

Nutomic closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Nutomic Awaiting requested review from Nutomic Nutomic will be requested when the pull request is marked ready for review Nutomic is a code owner

dessalines Awaiting requested review from dessalines dessalines will be requested when the pull request is marked ready for review dessalines is a code owner

Labels

None yet