Some material 3 cleanups. #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding a fade to the post body preview. - Getting rid of muted, using colorScheme.outlined instead. - Making label-type text use label rather than body style. - Getting rid of some unecessary surface and onSurface colors. - Fixes #1608
MV-GH
reviewed
Aug 6, 2024
| @@ -474,7 +474,7 @@ fun communityNameShown(community: Community): String = | |||
|
|
|||
| fun hostName(url: String): String? = | |||
| try { | |||
| URL(url).host | |||
There was a problem hiding this comment.
Its to show the hostname of the site for any posts with links / ones that have a URL. IE that washingtonpost.com in the screenshot above.
The only thing changed here is to remove the www., which a lot of links have and wasted screen space.
There was a problem hiding this comment.
Create a different function for that. And only use for the "Shown" purposes. But right now it is also used functionality wise to compare between hosts.
MV-GH
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onSurfacefor everything. #1608Example: