Filter_removed_comments_from_search

[tracyspacy]

As proposed in #4576

[SleeplessOne1917]

Should deleted comments also be filtered out?

[Nutomic]

This is the wrong place to change it as its also used to get the comments for a post among other things. Its necessary to show removed comments there so they can be restored. As its only about search you should filter them in search.rs instead. Or possibly add a parameter CommentQuery.include_deleted but thats probably not necessary.

[tracyspacy]

@Nutomic got your point. Added filter for removed comments in search.rs . Deleted comments are still shown in search results, should they remain or not?

[Nutomic]

It should be fine to exclude them as well.

[dessalines]

This isn't the right way to handle it either, filtering needs to be in SQL.

In the comment query logic, you can check for search_term (since if that's provided, you know its a search), and filter out deleted and removed based on that.

[tracyspacy]

In this case, we can do it this way:
in comment_veiw

we can add a new option to CommentQuery sctruct
like

pub struct CommentQuery<'a> {
  ...
  pub filter_removed_and_deleted: bool,
  ...
}

and in fn queries we can add a corresponding check if filter

if options.filter_removed_and_deleted {
      query = query.filter(comment::deleted.eq(false).and(comment::removed.eq(false)));
    }

and in search.rs
we just need to add this option to filter out deleted and removed comments

 comments = CommentQuery {
        sort: (sort.map(post_to_comment_sort_type)),
        listing_type: (listing_type),
        search_term: (Some(q)),
        filter_removed_and_deleted: (false),    // < - adding option to filter deleted and removed comments
        community_id: (community_id),
        creator_id: (creator_id),
        local_user: (local_user_view.as_ref()),
        page: (page),
        limit: (limit),
        ..Default::default()
      }
      .list(&mut context.pool())
      .await?;

@dessalines what do you think about it?

[dessalines]

First try to add that here, into the existing if let Some(search) .

If that fails tho, your approach looks good also.