Implement private communities #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
private-community
branch
from
fa6d326 to
3d416dd
Compare
Nutomic
force-pushed
the
private-community
branch
from
8fa2cee to
1a8d103
Compare
Nutomic
force-pushed
the
private-community
branch
2 times, most recently
from
fe83b43 to
ad532f5
Compare
Nutomic
force-pushed
the
private-community
branch
from
ad532f5 to
68d4ca9
Compare
Nutomic
force-pushed
the
private-community
branch
from
8c3f0c6 to
61a1e9b
Compare
Nutomic
force-pushed
the
private-community
branch
from
61a1e9b to
9e12028
Compare
|
Found the problem, the ci check for check_diesel_schema was not working correctly and it actually changed schema.rs while running migrations. The thing is with the extra foreign key reference, community_follower isnt joinable to person anymore, so the on clause has to be specified explicity every time. |
dullbananas
approved these changes
Oct 31, 2024
crates/api_common/src/community.rs
Outdated
Comment on lines
247
to
257
| #[derive(Debug, Serialize, Deserialize, Clone)] | ||
| #[cfg_attr(feature = "full", derive(TS))] | ||
| #[cfg_attr(feature = "full", ts(export))] | ||
| pub struct ListCommunityPendingFollows { | ||
| /// Only shows the unapproved applications | ||
| pub pending_only: Option<bool>, | ||
| // Only for admins, show pending follows for communities which you dont moderate | ||
| pub all_communities: Option<bool>, | ||
| pub page: Option<i64>, | ||
| pub limit: Option<i64>, | ||
| } |
There was a problem hiding this comment.
Should probably have a skip_serializing_none.
dessalines
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
Besidel @SleeplessOne1917 's comment everything looks good. I updated from main in case that was one of the test failures.
|
I fixed one test failure, but now it keeps throwing this error which I cant reproduce locally, and seems completely unrelated. |
SleeplessOne1917
approved these changes
Nov 5, 2024
Nutomic
force-pushed
the
private-community
branch
from
cf49e2d to
3668da8
Compare
Nutomic
force-pushed
the
private-community
branch
from
9c5a3fd to
a77edc8
Compare
Nutomic
force-pushed
the
private-community
branch
from
b7cc812 to
c7705cd
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/LemmyNet/rfcs/blob/main/0005-private-communities.md
CommunityVisibility::PrivateCommunityFollower.pending(bool) toCommunityFollower.state(Accepted/Pending,ApprovalRequired)GET /community/pending_follows/count,GET /community/pending_follows/list,POST /community/pending_follows/approveis_new_instancefor/api/v3/community/pending_follows/listitemsHide private content in RSS feeds(not necessary, already handled via post_view.rs