Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure searchOn and GKFAS return an arrayref #8

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

maxbes
Copy link
Contributor

@maxbes maxbes commented Sep 26, 2019

All Apache::Session::Browseable modules return an empty array ref when searchOn cannot find any sessions. Except this one which returns "undef"

This is causing issues when using LemonLDAP::NG in a REST session configuration because the Apache::Session::REST will crash on invalid JSON if an empty string is returned by Lemonldap::NG::Portal::Plugins::RESTServer.

This commit will make RESTServer return '{}' instead, which is correct JSON and will not crash Apache::Session::REST

@guimard guimard merged commit 4250a0c into LemonLDAPNG:master Sep 26, 2019
@maxbes maxbes deleted the return-array-ref branch September 26, 2019 19:12
@coudot coudot added this to the 0.20 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants