Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker should install extra deps + workflow trigger fix #86

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

LemurPwned
Copy link
Owner

@LemurPwned LemurPwned commented Dec 6, 2024

Summary by Sourcery

Update the Dockerfile to install additional dependencies using the extras_require feature and modify the GitHub Actions workflow to trigger on changes to specific file types and paths. Add a step to retrieve the version from setup.py in the workflow and use it for creating releases.

Build:

  • Update Dockerfile to install additional dependencies using the extras_require feature.

CI:

  • Modify GitHub Actions workflow to trigger on changes to specific file types and paths.
  • Add a step to retrieve the version from setup.py in the GitHub Actions workflow.

Copy link
Contributor

sourcery-ai bot commented Dec 6, 2024

Reviewer's Guide by Sourcery

This PR makes two main changes: it modifies the GitHub Actions workflow to improve release automation and updates the Docker installation process. The workflow changes include adding path filters for triggers, removing manual version input, and automating version extraction from setup.py. The Docker changes simplify dependency installation by using the [utils] extra.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Improved GitHub Actions workflow automation for releases
  • Added path filters to trigger workflow only on relevant file changes
  • Removed manual release version input requirement
  • Added version extraction from setup.py
  • Updated release creation to use extracted version
  • Added version extraction step to all jobs
.github/workflows/main.yml
Simplified Docker installation process
  • Replaced individual pip installs with single command using [utils] extra
  • Removed explicit numpy and scipy installations
docker/Dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LemurPwned - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LemurPwned LemurPwned merged commit 13a504e into master Dec 6, 2024
6 checks passed
@LemurPwned LemurPwned deleted the feat/workflow-fixes branch December 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant