Add option for Actors to delay a response #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is useful to delay sending a response, but still allow the actor to process other messages. It can be useful in cases, where the actor needs to persist some data or make external requests, does not need a &mut self but the message response does depend on result of the persistence operation. In this case it would be possible to do something like
tokio::spawn(async move { persist().await; sender.send(Ok(())) } );
This PR exposes the response oneshot sender to the actor through a new method, which actor definitions may override if they wish to. Now, I am not sure if the option to process other messages before sending a response breaks soundness or creates other issues, but I did not find any. One small issue I found is that measuring the time for metrics purposes might be misleading, if the response is actually delayed, as it measures the time for the handle() function to return, not actual sending of the response.
Let me know if there are any issues :)