Skip to content

Commit

Permalink
Ensure scons source isn't obfuscated by liblouis test tables target (n…
Browse files Browse the repository at this point in the history
…vaccess#16537)

Fixes nvaccess#16535
Fixup of nvaccess#16208

Summary of the issue:
nvaccess#16208 introduced test tables SCons didn't want to copy to the test directory by default. I tried to fix that by binding testTable to the source target with env.Alias, but that's definitely the wrong way.

Description of user facing changes
Fixed build system.

Description of development approach
Added the test tables as a dependency to the liblouis python wrapper. This ensures that test tables will be there when the python wrapper is build.
  • Loading branch information
LeonarddeR authored May 13, 2024
1 parent 7bb415d commit 49045d2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions nvdaHelper/liblouis/sconscript
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,5 @@ env.Depends(testTable, env.Install(unitTestTablesDir, [
louisTableDir.File("latinLetterDef8Dots.uti"),
louisTableDir.File("en-us-comp8-ext.utb")
]))
# Ensure the braille tables for tests are installed with scons source
env.Alias("source", testTable)
# Ensure the braille tables for tests are installed when copying the louis wrapper
env.Depends(louisPython, testTable)

0 comments on commit 49045d2

Please sign in to comment.