-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented buildObjectExplicit for building an xml string from a json object created with explicitChildren #307
base: master
Are you sure you want to change the base?
Conversation
flodev
commented
Jul 4, 2016
- fixed trimming of child text items
- implemented that single text nodes wont get trimmed
- fixed catching undefined text value
- added comments, fixed non cdata values like numbers
- added onclosetag and onopentag events
- fixed trimming of child text items - implemented that single text nodes wont get trimmed - fixed catching undefined text value - added comments, fixed non cdata values like numbers - added onclosetag and onopentag events
Is it possible to have this functionality soon please? Without proper XML serialization it draws this library unusable for our company's use case. |
can this please be merged? |
@flodev Hi, Can this be merge soon please? |
hi @Leonidas-from-XIV if the coverage increased and all tests passed, is there any other objection to merge this PR? |
What is blocking is that the branch is currently not mergeable because of conflicts with master. If someone is willing to rebase it and make sure there are no regressions I can merge it. Although I would prefer that the |
Sorry I don't have time get into the code again. |