adding parseStringSync + simple tests (continued) #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrparkers About that comment: the (Also, sorry for taking so long, busy week) |
|
Okay, I will try to address this when I have some free time. Thanks! |
mckramer
added a commit
to mckramer/node-xml2js
that referenced
this pull request
Feb 13, 2018
Create a sync version of parseString to API to permit
calling without a callback.
The current implemenation is sync due to underlying
implementation of SAX parser.
Examples:
```js
// Via root API
var result = xml2js.parseStringSync('< ... >', options)
// Via parser
var parser = new xml2js.Parser(options);
var result = parser.parseStringSync('< ... >');
```
See Leonidas-from-XIV#241 by @nobodyname
See Leonidas-from-XIV#319 by @mrparkers
mckramer
added a commit
to mckramer/node-xml2js
that referenced
this pull request
Feb 13, 2018
Create a sync version of parseString to API to permit
calling without a callback.
The current implemenation is sync due to underlying
implementation of SAX parser.
Examples:
```js
// Via root API
var result = xml2js.parseStringSync('< ... >', options)
// Via parser
var parser = new xml2js.Parser(options);
var result = parser.parseStringSync('< ... >');
```
See Leonidas-from-XIV#241 by @nobodyman
See Leonidas-from-XIV#319 by @mrparkers
|
Rebased these changes and added support for options in #422 |
|
Thanks @mckramer, I'll close this in favor of your PR. I haven't needed this for quite some time now. |
mckramer
added a commit
to mckramer/node-xml2js
that referenced
this pull request
Mar 12, 2018
Create a sync version of parseString to API to permit
calling without a callback.
The current implemenation is sync due to underlying
implementation of SAX parser.
Examples:
```js
// Via root API
var result = xml2js.parseStringSync('< ... >', options)
// Via parser
var parser = new xml2js.Parser(options);
var result = parser.parseStringSync('< ... >');
```
See Leonidas-from-XIV#241 by @nobodyman
See Leonidas-from-XIV#319 by @mrparkers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for getting this in so late, I haven't had the free time to work on this until now.
This PR is to address the comments made by @Leonidas-from-XIV in #241. Please refer to that PR for more context around these changes.
I'm pretty sure I got everything, except I was a bit confused by the comment asking for
parseStringSyncto adhere to the API ofparseString. If that could get cleared up for me, I can take a stab at that as well.Thanks!