Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Awww it's so fuzzy! #49

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Awww it's so fuzzy! #49

wants to merge 4 commits into from

Conversation

killercup
Copy link
Contributor

Re: #40 (comment)

This PR

  • adds some fuzzer documentation/introduction,
  • runs fuzzer with debug assertions (they should really hold),
  • and finally adds a Travis build that does nothing but run the fuzzer for 20s. I think it's a good idea to make this fail the build: It's easy to overlook otherwise and the fuzzer seems pretty stable right now, so it'll probably find actual bugs in the future. We can pin the nightly to a specific version to make it even more stable.

@killercup
Make fuzzer use debug assertions
021fbd4
@killercup
Add a Readme to fuzzer directory
2a93c76
@killercup
Run fuzzer for 20 seconds on travis
dc092c7 
I think it's fine to run this *and fail CI on it* because in my
experience nobody will notice that it's broken otherwise. Additionally,
the fuzzer here seems pretty stable. And if it actually found a panic,
you should know about it.
@killercup
Copy link
Contributor Author

Ha, and it fails. No idea what this means specifically, especially since the base64 it outputs is empty.

==7231==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1

I guess I'm gonna do that then.

Also, 20s seems to be on 152,096 runs and a coverage of 1753 code paths. With some demo files, it goes up to 2467 on my machine. I'll increase it to 60 seconds for now, and maybe we can copy the toml files already used in tests as corpus as well.

@killercup killercup force-pushed the feature/fuzz-on-ci branch 4 times, most recently from a2402f8 to 0fde164 Compare December 8, 2017 19:52
@killercup
Pascal vs. Travis
419489e 
(will amend and force-push this commit until it's green)
@killercup
Copy link
Contributor Author

You've got to be kidding me. ==7641==LeakSanitizer has encountered a fatal error. even though I disabled it with -detect_leaks=0…

@Manishearth, you managed to get cargo-fuzz's CI running. What dark magic did you use? Does using GCC5 make the difference? Is it because I forgot to do this last week when there as a super moon?

@Manishearth
Copy link

nooooo idea

@LeopoldArkham
Copy link
Owner

My thoughts are with you at this difficult time. Summon the eldritch powers, Pascal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@killercup @Manishearth @LeopoldArkham