This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 52
Add db.getMany(keys)
#381
Merged
Add db.getMany(keys)
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
enhancement
New feature or request
semver-minor
New features that are backward compatible
labels
Sep 25, 2021
This was referenced Sep 25, 2021
vweevers
commented
Sep 25, 2021
|
||
this._getMany(serialized, options, callback) | ||
return callback.promise | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that here we're doing everything that levelup normally does, as an experiment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which means that levelup
only has to do this:
LevelUP.prototype.getMany = function (keys, options, callback) {
return this.db.getMany(keys, options, callback)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So later on we can move over the catering
stuff to abstract-leveldown
one by one.
vweevers
commented
Sep 25, 2021
vweevers
commented
Sep 25, 2021
15 tasks
This was referenced Sep 25, 2021
This was referenced Sep 25, 2021
Added in the last commit (1f1ab97):
And removed:
|
ralphtheninja
approved these changes
Sep 28, 2021
vweevers
added a commit
to Level/subleveldown
that referenced
this pull request
Oct 1, 2021
vweevers
added a commit
to Level/subleveldown
that referenced
this pull request
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against
leveldown
,memdown
,level-js
,deferred-leveldown
,encoding-down
, (indirectly)levelup
,subleveldown
.Ref Level/community#101