-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yield LEVEL_LOCKED
error when lock is held
#8
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
'use strict' | ||
|
||
const test = require('tape') | ||
const tempy = require('tempy') | ||
const fork = require('child_process').fork | ||
const path = require('path') | ||
const { ClassicLevel } = require('..') | ||
|
||
test('lock held by same process', async function (t) { | ||
t.plan(2) | ||
|
||
const location = tempy.directory() | ||
const db1 = new ClassicLevel(location) | ||
await db1.open() | ||
const db2 = new ClassicLevel(location) | ||
|
||
try { | ||
await db2.open() | ||
} catch (err) { | ||
t.is(err.code, 'LEVEL_DATABASE_NOT_OPEN', 'second instance failed to open') | ||
t.is(err.cause.code, 'LEVEL_LOCKED', 'second instance got lock error') | ||
} | ||
|
||
return db1.close() | ||
}) | ||
|
||
test('lock held by other process', function (t) { | ||
t.plan(6) | ||
|
||
const location = tempy.directory() | ||
const db = new ClassicLevel(location) | ||
|
||
db.open(function (err) { | ||
t.ifError(err, 'no open error') | ||
|
||
const child = fork(path.join(__dirname, 'lock.js'), [location]) | ||
|
||
child.on('message', function (err) { | ||
t.is(err.code, 'LEVEL_DATABASE_NOT_OPEN', 'second process failed to open') | ||
t.is(err.cause.code, 'LEVEL_LOCKED', 'second process got lock error') | ||
|
||
child.disconnect() | ||
}) | ||
|
||
child.on('exit', function (code, sig) { | ||
t.is(code, 0, 'child exited normally') | ||
t.is(sig, null, 'not terminated due to signal') | ||
|
||
db.close(t.ifError.bind(t)) | ||
}) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
'use strict' | ||
|
||
const { ClassicLevel } = require('..') | ||
|
||
const location = process.argv[2] | ||
const db = new ClassicLevel(location) | ||
|
||
db.open(function (err) { | ||
process.send(err) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This platform difference will be gone once we upgrade LevelDB - but we'll still have to compare the error message. I don't see a cleaner way atm, short of patching upstream to return a more specific
leveldb::Status
.