This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
fix: add buffer #191
Merged
fix: add buffer #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
vweevers
reviewed
Mar 27, 2020
vweevers
reviewed
Mar 27, 2020
vweevers
approved these changes
Mar 28, 2020
|
@hugomrdias /cc @achingbrain IIRC ipfs is on level-js@4, so this will need a backport? |
|
im upgrading to 5 we should not have problems with the serialisation changes. |
vweevers
reviewed
Apr 3, 2020
|
5.0.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
bufferdependency, so we don't need to rely on bundlers outdated magic injections, webpack 5 will actually stop injecting node globals and electron renderer also has issues with undefined node globals depending on how the users compiles and runs the code.