Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump leveldown version for iojs compat #18

Closed
wants to merge 1 commit into from

Conversation

yoshuawuyts
Copy link

This bumps the leveldown version to ensure io.js compatibility. Might warrant a major version bump since leveldown also went post 1.0.0. Thanks!

Ps. By merging this you help in bringing clocker to io.js!

@rvagg
Copy link
Member

rvagg commented Jan 27, 2015

this has to wait for levelup@1.0.0 unfortunately

the interim solution is to backport io.js support to leveldown@0.10 which is a WIP (there's a PR for this)

@yoshuawuyts
Copy link
Author

Ah, I see. Adding links for completion:

@rvagg
Copy link
Member

rvagg commented Jan 27, 2015

levelup 1.0.0 has become our (my?) node 0.12 ... we need to cut cut cut and ship, I just need to find a few free hours to make it all happen but that's kind of tricky right now (would you rather me put my limited spare time in to io.js or level?)

@yoshuawuyts
Copy link
Author

Oh, I didn't mean to sound disgruntled, apologies if it appeared like that! Really appreciate what you've done with the place, hah. The 0.10 backport looks promising. Closing this PR in favor of a new one once the backport is released.

@yoshuawuyts yoshuawuyts deleted the leveldown_version branch January 27, 2015 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants