Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoding options on chained batch #633

Closed
4 tasks done
vweevers opened this issue Dec 31, 2018 · 2 comments
Closed
4 tasks done

Support encoding options on chained batch #633

vweevers opened this issue Dec 31, 2018 · 2 comments
Labels
enhancement New feature or request semver-minor New features that are backward compatible

Comments

@vweevers
Copy link
Member

vweevers commented Dec 31, 2018

While we support passing options to chainedBatch.write(), encoding-down encodes keys and values before write() is called. We can keep that as-is, but should allow encoding options on chainedBatch.put() and chainedBatch.del().

E.g.: chainedBatch.put(key, value, options).

To be added to:

@vweevers vweevers added the enhancement New feature or request label Dec 31, 2018
@vweevers vweevers added the documentation Improvements or additions to documentation label Jan 1, 2019
@vweevers vweevers added the semver-minor New features that are backward compatible label Mar 31, 2019
@liximomo
Copy link

Really need this

vweevers added a commit to Level/abstract-leveldown that referenced this issue Apr 9, 2021
vweevers added a commit to Level/abstract-leveldown that referenced this issue Apr 9, 2021
vweevers added a commit to Level/encoding-down that referenced this issue Apr 9, 2021
@vweevers vweevers changed the title Support encoding options (and similar) on chained batch Support encoding options on chained batch Apr 10, 2021
@vweevers vweevers removed the documentation Improvements or additions to documentation label Apr 17, 2021
@vweevers
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-minor New features that are backward compatible
Projects
None yet
Development

No branches or pull requests

2 participants