Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Added option 'createIfPathInexistent'. #135 #136

Closed
wants to merge 2 commits into from
Closed

Conversation

19h
Copy link

@19h 19h commented May 10, 2013

Added option 'createIfPathInexistent' to recursively create a path to the given database if it doesn't exist. Includes changes in documentation and is tested.

Implements the feature as discussed in #135.

@19h
Copy link
Author

19h commented May 10, 2013

Fails at leveldown-substitution-test.js since /somewhere/not/writable/booya! doesn't exist.

@rvagg
Copy link
Member

rvagg commented May 10, 2013

@KenanSulayman as @juliangruber said, this is far out of the scope of LevelUP, and as you've discovered with leveldown-substitution-test.js, LevelUP doesn't necessarily even need to be run with a filesystem backend--version 0.9 is going to decouple it from LevelDOWN in fact so you can use it with an in-memory backend (memdown), a browser back-end (level.js) or something else.

If anything, this is a LevelDOWN thing, but even there, I'd still argue that it's out of the scope of what we're doing there--which is exposing LevelDB functionality.

The best we can do is work towards fixing the stupid error message in LevelDB itself. This has come up before and I think we ought to submit a patch to LevelDB to be more helpful in this respect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants