-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support options passed to .open #660
Conversation
LevelDown supports an [optional `options` argument](https://github.com/Level/abstract-leveldown#dbopenoptions-callback) passed the `db.open` method. Currently LevelUp fails if options are passed to `.open` so this PR adds support for that.
Options that you pass to the And personally I'm hoping we can move away from |
That behaviour is maintained.
Sounds like a good plan, but if the goal here is to support the same API as |
That's not - or has not been - the goal. However there is a long-term goal to merge |
This needs a follow-up; browser tests are failing on the use of arrow functions. |
4.1.0 |
LevelDown supports an optional
options
argument passed thedb.open
method. Currently LevelUp fails if options are passed to.open
as it tries to invoke them as the callback so this PR adds support for that.By and large you don't call
.open
directly but if you do (or an intermediate module does as in my case) LevelUp should probably honour the api.