Improve Success Message #7
Conversation
Provide the caller with a copy-pastable activation command
| @@ -131,8 +131,10 @@ module.exports = CoreObject.extend({ | |||
| _deploySuccessMessage: function(revisionKey) { | |||
| var success = green('\nUpload successful!\n\n'); | |||
| var uploadMessage = white('Uploaded revision: ')+green(revisionKey); | |||
| var exampleCommand = white('To activate, execute: \n\n')+ | |||
| green('ember deploy:activate -r ' + revisionKey + '-e ' + this.config.environment); | |||
There was a problem hiding this comment.
@LevelbossMike this most likely won't work, since this.config.environment is a guessed variable, and most likely undefined.
What would be the best way to access the environment?
There was a problem hiding this comment.
Unfortunately you don't have access to the environment via the config object. this will be possible in the upcoming versions of ember-deploy with the deployment-pipeline and the new hooks-architecture.
There was a problem hiding this comment.
You could patch this in the configuration-reader of ember-cli-deploy and pass the environment there but this is kind of messy and will be fixed via the upcoming changes in ember-cli-deploy itself.
This would be a great addition to ember-deploy-redis. Thanks for catching this. I'll leave this open and ping you when ember-cli-deploy is ready.
There was a problem hiding this comment.
👍 thanks I'll keep my eyes peeled
Provide the caller with a copy-pastable activation command