Add support for -H
#1
Conversation
There was a problem hiding this comment.
I left a few comments below. Also, note that the Dune codebase is formatted using ocamlformat; you should install it in your switch and do make fmt to auto-format your changes. But note that you will have to do that in a 5.2 (or earlier) switch because ocamlformat does not yet support 5.3.
MA0010
force-pushed
the
hidden_deps
branch
2 times, most recently
from
44a170e to
58445e1
Compare
There was a problem hiding this comment.
Left some comments. The code of the test can be improved, but I will do that in a follow-up review.
Once the changes of the review have been done, I would like you to experiment with the following change to make the diff cleaner and less invasiave:
Instead of changing the interface of Lib_flags.L.include_flags to take a (Lib.t * bool) list, let's keep Lib.t list (= t) and instead let us pass an optional parameter ?hidden:(Lib.t -> bool) which would be only passed when called from Compilation_context.t. Thanks!
src/dune_rules/lib_flags.ml
Outdated
| ;; | ||
|
|
||
| type mode = | ||
| { lib_mode : Lib_mode.t | ||
| ; melange_emit : bool | ||
| } | ||
|
|
||
| let include_paths = | ||
| let add_public_dir ~visible_cmi obj_dir acc mode = | ||
| let include_paths_gen = |
There was a problem hiding this comment.
~init, ~add and ~remove should be arguments of include_paths_gen directly.
src/dune_rules/lib_flags.ml
Outdated
| let add acc p _ = Path.Set.add acc p in | ||
| let remove = Path.Set.remove in |
There was a problem hiding this comment.
Let's inline these two definitions.
src/ocaml/version.mli
Outdated
| @@ -76,3 +76,6 @@ val has_META_files : t -> bool | |||
|
|
|||
| (** Whether the compiler supports occurrences indexation *) | |||
| val supports_bin_annot_occurrences : t -> bool | |||
|
|
|||
| (**Whether the compiler supports -H flag for including libs*) | |||
There was a problem hiding this comment.
| (**Whether the compiler supports -H flag for including libs*) | |
| (** Whether the compiler supports the -H flag *) |
| > "No input files") | ||
| > dune build | ||
| > ;; | ||
| > esac |
|
To be continued upstream. |
This PR is not for merging, but to discuss @MA0010's progress on his current task (which, as the title indicates, is to add support for
-Hflag to Dune, see ocaml/ocaml#12246 and ocaml#9333).